Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates warnings, etc. #478

Merged
merged 13 commits into from
Oct 11, 2022
Merged

Updates warnings, etc. #478

merged 13 commits into from
Oct 11, 2022

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 9, 2022

This PR provides solutions for several newish warning cropping up in CI:

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #478 (a2e8ca2) into master (ac132a1) will increase coverage by 0.0%.
The diff coverage is 84.2%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #478   +/-   ##
======================================
  Coverage    79.3%   79.4%           
======================================
  Files         122     121    -1     
  Lines       12971   12973    +2     
======================================
+ Hits        10291   10299    +8     
+ Misses       2680    2674    -6     
Impacted Files Coverage Δ
libpysal/io/iohandlers/tests/test_db.py 50.0% <0.0%> (-5.6%) ⬇️
libpysal/weights/adjtools.py 84.9% <88.9%> (ø)
libpysal/weights/spatial_lag.py 93.0% <100.0%> (ø)
libpysal/weights/tests/test_adjlist.py 100.0% <100.0%> (ø)
libpysal/weights/tests/test_util.py 99.1% <100.0%> (ø)
libpysal/weights/util.py 78.1% <0.0%> (-0.4%) ⬇️
libpysal/weights/weights.py 80.9% <0.0%> (-0.4%) ⬇️
libpysal/__init__.py
libpysal/_version.py 40.7% <0.0%> (+2.7%) ⬆️
libpysal/examples/base.py 67.8% <0.0%> (+3.4%) ⬆️

libpysal/io/iohandlers/tests/test_db.py Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Member Author

Let's wait a day or so to merge this in case @sjsrey has any input.

@jGaboardi jGaboardi merged commit 284d2ae into pysal:master Oct 11, 2022
@jGaboardi
Copy link
Member Author

What are y'all's thoughts for a v4.7.1 patch release?

@jGaboardi jGaboardi deleted the updates_warnings branch October 11, 2022 23:03
jGaboardi added a commit to jGaboardi/spopt that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants