Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set instead of True-only dict for non-public names #4381

Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented May 22, 2024

Summary of changes

Extracted from #4366 to only include internal values.

Pull Request Checklist

  • Changes have tests (existing tests should pass)
  • News fragment added in newsfragments/. (no public-facing changes)
    (See documentation for details)

@Avasam Avasam force-pushed the Use-set-instead-of-True-only-dict-non-public branch from c82ba1a to 0ab0a4d Compare May 22, 2024 16:12
@Avasam Avasam mentioned this pull request May 22, 2024
2 tasks
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@abravalheri abravalheri merged commit 11bd24c into pypa:main Jun 24, 2024
20 of 22 checks passed
@Avasam Avasam deleted the Use-set-instead-of-True-only-dict-non-public branch June 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants