-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from tox to Nox #10693
Move from tox to Nox #10693
Conversation
That way, we can move from tox to Nox without problems. See pypa#6721 for details.
- Simplify it, by replacing a run with a Python if statement. - Pass an env argument to the coverage call to ensure it will work.
Ok... after a (really) dirty commit history, I think this is ready. What do you think? |
🎉 |
Just give me a minute to fix this mess... |
24c1522
to
093ef1d
Compare
Ok, I think that's all from my side. |
Thanks for putting the work in here @DiddiLeija! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to add a session for vendoring, and change our CI to use it.
@pradyunsg thanks for the suggestions, I'll be working on them today. |
We already have a Lines 172 to 173 in 9cf35b2
We can just implement it in our CI, right? |
All done now. Any other commentaries? |
@pradyunsg I made your suggestions. |
@pradyunsg feel free to merge this pull request! |
Thanks for the nudge! ^>^ |
Closes #6721. Move all our CI from tox to Nox, and update documentation.
@pypa/pip-team @theacodes