Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable location warning #10148

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Re-enable location warning #10148

merged 1 commit into from
Jul 12, 2021

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 9, 2021

We’ve since fixed the previously reported location warnings, time to try again…?

@uranusjr uranusjr added this to the 21.2 milestone Jul 9, 2021
@uranusjr
Copy link
Member Author

I’ve opened #10151 for this. Will update the PR soon to use that issue.

@uranusjr uranusjr force-pushed the location-warning-again branch 2 times, most recently from 60d73ae to 802fc20 Compare July 10, 2021 02:20
@uranusjr
Copy link
Member Author

uranusjr commented Jul 12, 2021 •
edited
Loading

I want to take another look at #9865 and #9844 first and merge them before doing this.

Edit: Also #10145

@uranusjr
Copy link
Member Author

I think we are ready. Fingers crossed…

@uranusjr uranusjr merged commit cccf380 into pypa:main Jul 12, 2021
@uranusjr uranusjr deleted the location-warning-again branch July 12, 2021 19:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.2
Development

Successfully merging this pull request may close these issues.
2 participants
@uranusjr @pradyunsg