Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor input parameter of the data loader in PolypharmacyDataset class #385

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

SinaTabakhi
Copy link
Member

Description

To improve readability, it is preferable to replace the cfg_dataset: CfgNode parameter in the PolypharmacyDataset class with its individual components, namely url, root, and name. This substitution will result in a clearer and more understandable implementation.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@SinaTabakhi SinaTabakhi added the refactor Refactor of existing code label Jun 14, 2023
@SinaTabakhi SinaTabakhi self-assigned this Jun 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #385 (8a0fe3a) into main (741aaaa) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files          49       49              
  Lines        5233     5234       +1     
==========================================
  Hits         4790     4790              
- Misses        443      444       +1     
Impacted Files Coverage Δ
kale/loaddata/polypharmacy_datasets.py 0.00% <0.00%> (ø)

Copy link
Member

@haipinglu haipinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this 👍

@haipinglu haipinglu merged commit 607c3cc into pykale:main Jun 15, 2023
8 checks passed
This was referenced Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor of existing code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants