Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPython version from <9.0 to <8.13 to support Python 3.8 #372

Merged
merged 5 commits into from
Apr 29, 2023

Conversation

xianyuanliu
Copy link
Member

@xianyuanliu xianyuanliu commented Apr 29, 2023

Fixes #371.

Description

Updates the version of IPython in the requirements and setup to support Python 3.8.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Merging #372 (4d39a15) into main (f732e72) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          48       48           
  Lines        5130     5130           
=======================================
  Hits         4688     4688           
  Misses        442      442           

@xianyuanliu xianyuanliu added the bug Something isn't working label Apr 29, 2023
Copy link
Member

@haipinglu haipinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your swift action Xianyuan!

@haipinglu haipinglu merged commit 665c6b4 into main Apr 29, 2023
9 checks passed
@haipinglu haipinglu deleted the freeze_ipython_version branch April 29, 2023 08:19
This was referenced Jul 13, 2023
@haipinglu haipinglu changed the title Update IPython version from <9.0 to <8.13 Update IPython version from <9.0 to <8.13 to support Python 3.8 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] The latest IPython does not support Python 3.8
3 participants