-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to log messages to terminal #358
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 91.38% 91.31% -0.07%
==========================================
Files 48 48
Lines 5130 5135 +5
==========================================
+ Hits 4688 4689 +1
- Misses 442 446 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Schobs Didn't pass all the checks.
checks not succesfull after updating the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Schobs Some minor changes needed before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_logger is coveraging 100% of logger. LGTM. Well done.
Fixes #{issue_number}.
Description
Adds option to log to terminal. THis is useful since we want to avoid print statements, and in interactive examples it is important to print to terminal. This will not affect any existing code since it defaults to False.
Status
Ready
If you've been given access to pykale with role Triage or above, on the right (delete these after selection):
If you cannot see an option to select a reviewer/label, that means one maintainer will get notified upon your pull request and then select for you.
Types of changes
docs
manually updated for new API.