Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create stale workflow #348

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Create stale workflow #348

merged 7 commits into from
Oct 6, 2022

Conversation

Mdnaimulislam
Copy link
Collaborator

@Mdnaimulislam Mdnaimulislam commented Sep 23, 2022 •
edited
Loading

Fixes https://github.com/pykale/pykale/projects/10#card-84917959

Description

Stale workflow has been created to mark stale issues and pull requests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@Mdnaimulislam
stale created
b91fd86 
stale workflow has been created to handle the issues and pull requests
@Mdnaimulislam Mdnaimulislam changed the title stale created stale workflow created Sep 23, 2022
@Mdnaimulislam Mdnaimulislam changed the title stale workflow created Create stale.yml Sep 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #348 (22f412c) into main (7331d56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          46       46           
  Lines        5078     5078           
=======================================
  Hits         4713     4713           
  Misses        365      365

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mdnaimulislam
Copy link
Collaborator Author

pre-commit has been checked for all the files.

@Mdnaimulislam
Copy link
Collaborator Author

Docs build fails on Sphinx==5.2.0.post0. It's a recent bug on new version. They didn't fixed the bug yet.
Possible solution: Use the previous version 5.1.1.

Source: readthedocs/sphinx_rtd_theme#1343

@haipinglu
Copy link
Member

Docs build fails on Sphinx==5.2.0.post0. It's a recent bug on new version. They didn't fixed the bug yet. Possible solution: Use the previous version 5.1.1.

Source: readthedocs/sphinx_rtd_theme#1343

The other PR has no issue with docs, see and compare with https://readthedocs.org/projects/pykale/builds/18167003/ to understand deeper.

@Mdnaimulislam
Copy link
Collaborator Author

1

This is the error message beacuase of Sphinx v5.2.0.post0 on my PR yesterday.

2

This PR didn't had the problem beacuse the pending version v5.2.1 has been released 3 hours ago. I am confident that it will not create any problem now. Can you run it again now once?

@haipinglu
Copy link
Member

@shuo-zhou Please think about setting the feasible/appropriate days in this workflow to discuss with me before merging.

@haipinglu haipinglu added this to In progress in v0.2.0 via automation Oct 6, 2022
@haipinglu haipinglu added the new feature New feature/module (including request) label Oct 6, 2022
haipinglu
haipinglu reviewed Oct 6, 2022
View reviewed changes
.github/workflows/stale.yml Outdated
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-issue-stale: 30
days-before-issue-close: 7
days-before-pr-stale: 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45 please

haipinglu
haipinglu reviewed Oct 6, 2022
View reviewed changes
.github/workflows/stale.yml Outdated
@@ -0,0 +1,30 @@
# This workflow will install Python dependencies, run tests, and report the coverage with a variety of Python versions and OSs
Copy link
Member

@haipinglu haipinglu Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong doc. Please fix. You should self-review everything before requesting review.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it. I will be careful about it next time. Thanks.

@haipinglu haipinglu changed the title Create stale.yml Create stale workflow Oct 6, 2022
@haipinglu haipinglu merged commit de78831 into pykale:main Oct 6, 2022
v0.2.0 automation moved this from In progress to Done Oct 6, 2022
This was referenced Jul 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haipinglu haipinglu haipinglu approved these changes

Assignees
No one assigned
Labels
new feature New feature/module (including request)
Projects
No open projects
v0.2.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mdnaimulislam @codecov-commenter @haipinglu