Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file path as a dicom dataset attribute #345

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

shuo-zhou
Copy link
Member

@shuo-zhou shuo-zhou commented Aug 25, 2022

Description

Add file path as a dicom dataset attribute.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@shuo-zhou shuo-zhou added the enhancement Improvement of existing code label Aug 25, 2022
@shuo-zhou shuo-zhou added this to In progress in v0.2.0 via automation Aug 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #345 (fdc3aff) into main (e8e1fd1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          46       46           
  Lines        5077     5078    +1     
=======================================
+ Hits         4712     4713    +1     
  Misses        365      365           
Impacted Files Coverage Δ
kale/loaddata/image_access.py 97.32% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shuo-zhou shuo-zhou requested a review from Schobs August 25, 2022 13:11
Copy link
Member

@Schobs Schobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change. Now when you load a DICOM, each phase image is saved along with an attribute called "FilePath" which links the filepath to the loaded image.

@shuo-zhou shuo-zhou merged commit fe3e506 into main Sep 8, 2022
v0.2.0 automation moved this from In progress to Done Sep 8, 2022
@shuo-zhou shuo-zhou deleted the dicom-access-class branch September 8, 2022 13:41
This was referenced Jul 13, 2023
@haipinglu haipinglu changed the title Add file path as a dicom dataset attribution Add file path as a dicom dataset attribute Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing code
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants