Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyecharts.render.snapshot 参数fix #1412

Merged
merged 8 commits into from
Nov 29, 2019
Merged

pyecharts.render.snapshot 参数fix #1412

merged 8 commits into from
Nov 29, 2019

Conversation

BradyHu
Copy link
Contributor

@BradyHu BradyHu commented Nov 14, 2019

本次 PR 内容,
修复snapshot_selenium 参数问题
before:非关键字传参,导致delay和pixel_ratio参数作用错位
after:fixed

@BradyHu BradyHu closed this Nov 14, 2019
@BradyHu BradyHu reopened this Nov 14, 2019
@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1412 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1412   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         104      104           
  Lines        2870     2870           
=======================================
  Hits         2709     2709           
  Misses        161      161
Impacted Files Coverage Δ
pyecharts/render/snapshot.py 71.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d13a6...a8da8f6. Read the comment docs.

@BradyHu
Copy link
Contributor Author

BradyHu commented Nov 14, 2019

啊啊啊 这个,可算是通过编译了,我太难了,...

@sunhailin-Leo
Copy link
Member

@BradyHu

  • 为了再让你巩固一下流程
    • 建议你从你仓库的 dev 分支提 pr,一来可以和主仓库代码同步
    • 参考地址:贡献说明

@sunhailin-Leo sunhailin-Leo merged commit d6d14c9 into pyecharts:dev Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants