Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Check for encoding mismatch with send_c_store() #893

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Dec 3, 2023

Reference issue

Check for a mismatch between transfer syntax and dataset encoding and either try to fix it or raise if unable to. Closes #891

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #893 (55c3b3f) into main (9dc16ef) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #893   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8690      8703   +13     
=========================================
+ Hits          8690      8703   +13     
Files Coverage Δ
pynetdicom/ae.py 100.00% <100.00%> (ø)
pynetdicom/association.py 100.00% <100.00%> (ø)

@scaramallion scaramallion merged commit 60088e7 into pydicom:main Dec 3, 2023
11 checks passed
@scaramallion scaramallion deleted the dev-encoding-exc branch December 3, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C-store image Fail
1 participant