Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add convenience function Event.encoded_dataset() #888

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Nov 17, 2023

Reference issue

Adds a convenience function for accessing the encoded dataset and file meta

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #888 (f8a1f4d) into main (37388d1) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #888      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           28       28              
  Lines         8663     8679      +16     
===========================================
+ Hits          8663     8666       +3     
- Misses           0       13      +13     
Files Coverage Δ
pynetdicom/dsutils.py 100.00% <100.00%> (ø)
pynetdicom/events.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@scaramallion scaramallion changed the title [WIP] Add convenience function Event.encoded_dataset() [MRG] Add convenience function Event.encoded_dataset() Nov 17, 2023
@scaramallion scaramallion merged commit d38eb18 into pydicom:main Nov 17, 2023
10 of 11 checks passed
@scaramallion scaramallion deleted the dev-event-write branch November 17, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant