Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Use list comprehension #868

Merged
merged 1 commit into from
Oct 8, 2023
Merged

[MRG] Use list comprehension #868

merged 1 commit into from
Oct 8, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 8, 2023 •
edited
Loading

Reference issue

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft October 8, 2023 14:27
@DimitriPapadopoulos DimitriPapadopoulos changed the title Use list comprehension [MRG] Use list comprehension Oct 8, 2023
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review October 8, 2023 14:45
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #868 (9c0b188) into master (ca798a7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #868   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8639      8621   -18     
=========================================
- Hits          8639      8621   -18
Files Coverage Δ
pynetdicom/pdu_items.py 100.00% <100.00%> (ø)

@scaramallion scaramallion merged commit 62bcad4 into pydicom:master Oct 8, 2023
15 checks passed
@scaramallion
Copy link
Member

Thanks!

@DimitriPapadopoulos DimitriPapadopoulos deleted the list_comprehension branch October 9, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaramallion scaramallion scaramallion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DimitriPapadopoulos @scaramallion