Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add better handling of invalid A-ASSOCIATE (RJ) parameters during ACSE negotiation #634

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

scaramallion
Copy link
Member

Reference issue

Related to #633, handle invalid result, source and diagnostic parameters in the A_ASSOCIATE string methods.

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Unit tests passing and coverage at 100% after adding fix/feature

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #634 (d92c5c3) into master (21c032f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #634   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         8630      8644   +14     
=========================================
+ Hits          8630      8644   +14     
Impacted Files Coverage Δ
pynetdicom/pdu.py 100.00% <100.00%> (ø)
pynetdicom/pdu_primitives.py 100.00% <100.00%> (ø)

@scaramallion scaramallion changed the title [WIP] Add better handling of invalid A-ASSOCIATE (RJ) parameters during ACSE negotiation [MRG] Add better handling of invalid A-ASSOCIATE (RJ) parameters during ACSE negotiation Jun 3, 2021
@scaramallion scaramallion merged commit dadbcf1 into pydicom:master Jun 3, 2021
@scaramallion scaramallion deleted the dev-valid branch June 3, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant