Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update type hints #630

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Jun 1, 2021

  • Type hints for event, fsm and _handlers
  • Fixes for AA-7 and AA-8

Tasks

  • Fix or feature added
  • Unit tests passing and coverage at 100% after adding fix/feature

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #630 (aa5f379) into master (0e8ac4b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         8561      8624   +63     
=========================================
+ Hits          8561      8624   +63     
Impacted Files Coverage Δ
pynetdicom/pdu_primitives.py 100.00% <ø> (ø)
pynetdicom/__init__.py 100.00% <100.00%> (ø)
pynetdicom/_handlers.py 100.00% <100.00%> (ø)
pynetdicom/acse.py 100.00% <100.00%> (ø)
pynetdicom/association.py 100.00% <100.00%> (ø)
pynetdicom/dimse.py 100.00% <100.00%> (ø)
pynetdicom/dimse_primitives.py 100.00% <100.00%> (ø)
pynetdicom/dul.py 100.00% <100.00%> (ø)
pynetdicom/events.py 100.00% <100.00%> (ø)
pynetdicom/fsm.py 100.00% <100.00%> (ø)
... and 2 more

@scaramallion scaramallion merged commit 5fdb872 into pydicom:master Jun 2, 2021
@scaramallion scaramallion deleted the dev-type-2 branch June 2, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant