Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Scheme Version erroneously seen as required #32

Closed
mrbean-bremen opened this issue Aug 6, 2023 · 0 comments · Fixed by #34
Closed

Coding Scheme Version erroneously seen as required #32

mrbean-bremen opened this issue Aug 6, 2023 · 0 comments · Fixed by #34
Labels
Milestone

Comments

@mrbean-bremen
Copy link
Member

This is another problem of the condition parser. The condition reads:

Required if the value of Coding Scheme Designator (0008,0102) is present and is not sufficient to identify the Code Value (0008,0100) or Long Code Value (0008,0119) unambiguously. Shall not be present if Coding Scheme Designator (0008,0102) is absent. May be present otherwise.

The part "Required if the value of Coding Scheme Designator (0008,0102) is present" is parsed correctly, but the second part "and is not sufficient to identify the Code Value (0008,0100) or Long Code Value (0008,0119) unambiguously" is ignored. It should instead be seen as unknown, so that the whole condition is be ignored, as there is not enough information for a valid decision.

@mrbean-bremen mrbean-bremen added this to the 0.4 milestone Aug 6, 2023
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 7, 2023
- caused false positives
- fixes pydicom#32
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 7, 2023
- caused false positives
- fixes pydicom#32
mrbean-bremen added a commit that referenced this issue Aug 8, 2023
- caused false positives
- fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant