Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants 'zero' and 'non-zero' are not handled #17

Closed
x44 opened this issue Jul 11, 2022 · 1 comment · Fixed by #18
Closed

Constants 'zero' and 'non-zero' are not handled #17

x44 opened this issue Jul 11, 2022 · 1 comment · Fixed by #18

Comments

@x44
Copy link

x44 commented Jul 11, 2022

I'm not sure if this is a bug.
condition_parser.py _get_const_value() returns (None, '') if the value is 'zero' or 'non-zero'.
Therefore, conditions such as
Number of Blocks (300A,00F0) is non-zero.
Number of Beams (300A,0080) is greater than zero.
are silently ignored.

In iod_validator.py _tag_matches() there is a TODO which could have something to do with this issue.

@mrbean-bremen
Copy link
Member

Yes, you are right, thank you! I'm going to fix this (up to a point, more complicated expressions will still be ignored).

mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Jul 11, 2022
mrbean-bremen added a commit that referenced this issue Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants