-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constants 'zero' and 'non-zero' are not handled #17
Comments
Yes, you are right, thank you! I'm going to fix this (up to a point, more complicated expressions will still be ignored). |
mrbean-bremen
added a commit
to mrbean-bremen/dicom-validator
that referenced
this issue
Jul 11, 2022
mrbean-bremen
added a commit
that referenced
this issue
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if this is a bug.
condition_parser.py _get_const_value() returns (None, '') if the value is 'zero' or 'non-zero'.
Therefore, conditions such as
Number of Blocks (300A,00F0) is non-zero.
Number of Beams (300A,0080) is greater than zero.
are silently ignored.
In iod_validator.py _tag_matches() there is a TODO which could have something to do with this issue.
The text was updated successfully, but these errors were encountered: