Faq pull request (According to pull request #7604 & issue #1285 #7638
Conversation
please look into the changes.
There was a problem hiding this comment.
Hi @harshitha1201 - thanks for working on this!
Is there are reason why you made a second pull request here rather than continuing with #7604? Generally we try to push more commits to the same branch, so as to keep a record of reviewer's feedback all in one place.
I've added a couple more suggestions anyway.
|
@TomNicholas I have made the changes as requested, please look into them |
I was unable to commit, so I created another PR. This won't happen again. |
|
@TomNicholas |
doc/getting-started-guide/faq.rst
Outdated
|
|
||
| NetCDF | ||
| ------ | ||
| If you are reading a netCDF file with a ".nc" extension, the default engine is `netcdf4`. However if you have files with non-standard extensions or if the file format is ambiguous. Specify the engine explicitly when reading files with xarray, to ensure that the correct backend is used. |
There was a problem hiding this comment.
Should we mention the scipy and h5netcdf engines here explicitely?
There was a problem hiding this comment.
I mentioned scipy engine, but I'm unable to open the netcdf4 file using h5netcdf engine.
|
@TomNicholas please review |
|
@headtr1ck I have done the changes as requested, please review |
|
@headtr1ck I have done the changes, please review |
|
@TomNicholas please review all the changes done. |
There was a problem hiding this comment.
This is looking pretty good to me now! Well done @harshitha1201 !
If others agree I will merge it.
Thank you! |
|
@harshitha1201 feel free to add an entry in doc/whats-new.rst. |
|
Sure, can you please elaborate @headtr1ck |
|
In https://github.com/pydata/xarray/blob/main/doc/whats-new.rst Add a line under the documentation section explaining what you have added. Use the rest of the file as a guideline on how to format. |
|
@headtr1ck done! Thank you |
|
Thanks for this contribution! |
Thank you. |
* main: (40 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...
|
Thanks @harshitha1201 ! A great usability improvement. |
Thanks! |
* upstream/main: (716 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...
@TomNicholas
Please review the changes
closes part of #1285