Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyval: Use Horner's algorithm + support chunked inputs #6548

Merged
merged 38 commits into from
May 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
e309682
new polyval algo
headtr1ck Apr 30, 2022
88e476a
polyval improved typing with datasets
headtr1ck Apr 30, 2022
261aadc
more polyval unit tests
headtr1ck Apr 30, 2022
2a6a633
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 30, 2022
a2701b8
support for Dataset coord in polyval
headtr1ck Apr 30, 2022
553de10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 30, 2022
4fbca23
fix bug in polyval broadcasting
headtr1ck Apr 30, 2022
b335679
Merge branch 'main' into main
max-sixty Apr 30, 2022
b54a4a3
Merge branch 'main' into main
max-sixty Apr 30, 2022
7001e4e
Merge branch 'main' into main
max-sixty Apr 30, 2022
212505f
support for datetime values in polyval
headtr1ck May 1, 2022
595c83c
Merge branch 'main' of github.com:headtr1ck/xarray into main
headtr1ck May 1, 2022
945cbfb
polyval update in whats-new
headtr1ck May 1, 2022
5945537
fix dask polyval unit tests
headtr1ck May 1, 2022
a0964ed
fix bug in polyval unit tests
headtr1ck May 1, 2022
82db394
add polyval benchmark
headtr1ck May 1, 2022
ca5a7f7
add breaking change of polyval tp whats-new
headtr1ck May 1, 2022
7a70831
move _ensure_numeric to its own function
headtr1ck May 1, 2022
401e126
fix import error in _ensure_numeric
headtr1ck May 1, 2022
3c21a64
add raise_if_dask_computes to polyval unit tests
headtr1ck May 1, 2022
ff37fe2
chunk coord arg as well for polyval unit tests
headtr1ck May 1, 2022
63ed137
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 1, 2022
8343b29
simplify polyval algo with sortby
headtr1ck May 1, 2022
7ad9168
Merge branch 'main' of github.com:headtr1ck/xarray into main
headtr1ck May 1, 2022
0ef3462
comment some code until PR#6556
headtr1ck May 1, 2022
e6f4675
Revert "comment some code until PR#6556"
headtr1ck May 1, 2022
3b88386
fix dask issues with polyval unit tests
headtr1ck May 1, 2022
ce392a7
remove unused import
headtr1ck May 1, 2022
4e8b72e
make polyval benchmark backwards compatible
headtr1ck May 1, 2022
70c4419
another bugfix for polyval benchmark
headtr1ck May 1, 2022
c4ced87
Update asv_bench/benchmarks/polyfit.py
dcherian May 2, 2022
7a73a42
Actually compute dask arrays in benchmark.
dcherian May 2, 2022
a824ad2
Minor cleanup
dcherian May 2, 2022
047cd04
simplify polyval algo using reindex
headtr1ck May 3, 2022
0d0bb8e
don't copy coeffs if not necessary
headtr1ck May 3, 2022
ef49710
Merge branch 'pydata:main' into main
headtr1ck May 3, 2022
05e0266
Make sure degree_dim is an indexed coordinate of int dtype
dcherian May 4, 2022
bd3dd81
Fix benchmark
dcherian May 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually compute dask arrays in benchmark.
  • Loading branch information
dcherian committed May 2, 2022
commit 7a73a4202aa1872ac25e86609e487834dba0d870
4 changes: 2 additions & 2 deletions asv_bench/benchmarks/polyfit.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ def setup(self, *args, **kwargs):
def time_polyval(self, nx, ndeg):
x = self.xs[nx]
c = self.coeffs[ndeg]
xr.polyval(x, c)
xr.polyval(x, c).compute()

@parameterized(["nx", "ndeg"], [nxs, ndegs])
def peakmem_polyval(self, nx, ndeg):
x = self.xs[nx]
c = self.coeffs[ndeg]
xr.polyval(x, c)
xr.polyval(x, c).compute()


class PolyvalDask(Polyval):
Expand Down