fix(2021): images not display #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwang44 我先開了Issue避免遺忘. 不過正要部署看看效果時發現"pycon_archive_past_website" 上次git更新是2021年? |
要看 gh-pages branch，main branch 是爬蟲的 source code |
|
@SivanYeh 我要先 merge 囉？ |
|
Go ahead! |
|
發現 2022 也是同樣問題，直接改完推進 gh-pages branch 了 |
|
目前頁面打開都還是會使用 /temp 上的 images，但 refresh 就會恢復，可能是哪邊 cache 住了，過一陣子再回來檢查 |
|
這邊其實不是從爬蟲爬的是走 nuxt generate 產生的靜態網站，當初少考慮到 temp server 會關掉 |
|
@josix 可以幫忙改一下 ticket description 嗎 🙏🏽 🙏🏽 🙏🏽 |
|
有勞兩位了🙏🏻🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
發現 2021 網站有有很多圖片都失效，例如所有演講者大頭貼
how
發現這些影像的 URL 都是
https://tw.pycon.org/temp/...，這是過去還在開發舊官網 archive 爬蟲程式時幫 2021 網站另外設定的 URL。先將其都改成https://tw.pycon.org/prs/...應該可以讓 2021 頁面順利顯示圖片，但這代表爬蟲程式當初沒有順利把所有 images 都給爬下來 archive，需要後續另外處理。（P.S. 2022 以後的網站都是從 GCS 拿圖片，相對安全但還是討論是否依舊存進這個 repo，更加降低維護的心力）