Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update show soft limit #905

Merged
merged 3 commits into from
Aug 30, 2020

Conversation

Maliaotw
Copy link
Contributor

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

update show soft limt change font color.

Related Issue

#879

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2020

Codecov Report

Merging #905 into master will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   75.66%   75.60%   -0.06%     
==========================================
  Files          80       80              
  Lines        3016     3034      +18     
==========================================
+ Hits         2282     2294      +12     
- Misses        734      740       +6     
Impacted Files Coverage Δ
src/ext2020/models.py 85.18% <50.00%> (-2.82%) ⬇️
src/ccip/urls.py 100.00% <0.00%> (ø)
src/events/templatetags/events.py 37.62% <0.00%> (ø)
src/events/models.py 87.40% <0.00%> (+0.09%) ⬆️
src/ext2020/views.py 55.00% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9829c4...71e8c37. Read the comment docs.

Copy link
Member

@yychen yychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他看起來沒啥問題喔,把顏色改一下就可以上了 :D

}

.text-yellow {
color: yellow;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊來個 #9c9313 好了,yellow 感覺會太亮跟底色不搭

Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Thanks for your work!

@mattwang44 mattwang44 merged commit 7261793 into pycontw:master Aug 30, 2020
MadRex2000 added a commit to MadRex2000/pycon.tw that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants