Short-term fix of issue 790 #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird. Why the comparison shows the extra commits...let me check. [updated] resolved by re-basing my branch on the top of master. |
tai271828
force-pushed
the
pr-fix-issue-790
branch
from
e7a27d2
to
9d2a8bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 70 70
Lines 2684 2684
=======================================
Hits 2028 2028
Misses 656 656 Continue to review full report at Codecov.
|
|
If we landed this pull request, we may want to keep issue #790 opened until we apply the "long-term" solution. |
tai271828
force-pushed
the
pr-fix-issue-790
branch
from
00ac4c7
to
d8aca4c
Compare
By applying pull request pycontw#772 we introduce this issue. This pull request applies a short-term fix according to the discussion of issue pycontw#790.
tai271828
force-pushed
the
pr-fix-issue-790
branch
from
d8aca4c
to
309933e
Compare
|
Besides trying |
yychen
approved these changes
Jun 7, 2020
gtbcoding
pushed a commit
to gtbcoding/pycon.tw
that referenced
this pull request
Jul 27, 2020
Short-term fix of issue 790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fix issue #790 with a short-term solution according to the discussion of the issue thread. (the way of symbolic link)
Steps to Test This Pull Request
docker-compose up -d --buildExpected behavior
The deployed site will be re-deployed.
Related Issue
Issue #790
More Information
Tested on our staging site.