Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(node): upgrade to node v20.11.0 and related dependency #1195

Merged
merged 3 commits into from
Jun 22, 2024
Merged

build(node): upgrade to node v20.11.0 and related dependency #1195

merged 3 commits into from
Jun 22, 2024

Conversation

rockleona
Copy link
Contributor

@rockleona rockleona commented May 6, 2024 •
edited
Loading

Types of changes

  • Other (please describe)

Description

  • Update Node to v20.11.0 (lts/iron)
  • Update some packages
    • autoprefixer
    • browserify
    • node-sass
    • postcss-cli

Related Issue

Ideal to resolve all Dependabot alerts

@rockleona
Copy link
Contributor Author

I was trying to run dev container on Windows WSL2 (Ubuntu 22.04), but will got this error when running docker-compose-dev.yml.

Will try to use Ubuntu tomorrow.

image

@mattwang44
Copy link
Member

mattwang44 commented May 6, 2024 •
edited
Loading

yap I've aware that the script cannot run on Windows...still WIP
#1192

hmmm it should have worked on WSL. Which docker version do you use now?

@mattwang44
Copy link
Member

should also edit the version defined in .github/workflows/ci.yaml for CI

@rockleona
Copy link
Contributor Author

hmmm it should have worked on WSL. Which docker version do you use now?

Wondering if this info is helpful or not

image

@rockleona
Copy link
Contributor Author

should also edit the version defined in .github/workflows/ci.yaml for CI

Sure, I just notice the ci error too, I think I will wait #1194 merged and edit all node version at once.

@rockleona
Copy link
Contributor Author

Hi @mattwang44, things getting weird now..., I checkout master branch to run enter_dev_env.sh on Ubuntu22.04, but still having this error, I'm wondering how should I do in this stage.😢

Error
image

Docker Version
image

@mattwang44
Copy link
Member

mattwang44 commented May 7, 2024 •
edited
Loading

QQ

  • Did you try cleanup the existing images & containers?
  • Would you please try to run the script on GitHub Codespace (it was functional a couple of weeks ago)?

I'm afraid that I do not have enough time to cope with this issue until next week.

@rockleona rockleona marked this pull request as ready for review May 31, 2024 10:11
@rockleona rockleona requested a review from mattwang44 May 31, 2024 10:11
@rockleona
Copy link
Contributor Author

Hi @mattwang44 , I think I'm making the first step done upgrading the node packages, please have a review.

@rockleona
Copy link
Contributor Author

QQ

  • Did you try cleanup the existing images & containers?
  • Would you please try to run the script on GitHub Codespace (it was functional a couple of weeks ago)?

I'm afraid that I do not have enough time to cope with this issue until next week.

And yes....., I totally forgot I did not cleanup all images, no wonder it always failed.

@mattwang44
Copy link
Member

有 conflict 記得先解掉歐～

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (0fa2454) to head (adeb5aa).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files          81       81           
  Lines        3057     3057           
=======================================
  Hits         2262     2262           
  Misses        795      795

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rockleona
rockleona commented Jun 4, 2024
View reviewed changes
Copy link
Contributor Author

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我 rebase 了！

Dockerfile Outdated Show resolved Hide resolved
src/pycontw2016/settings/base.py
@@ -265,7 +265,7 @@ def node_bin(name):
COMPRESS_SCSS_COMPILER_CMD = (
'{node_sass_bin} --include --output-style expanded {paths} '
'--include-path="{node_modules}" "{infile}" "{outfile}" && '
'{postcss_bin} --use "{node_modules}/autoprefixer" '
'{postcss_bin} --use "{node_modules}/autoprefixer/lib/autoprefixer.js" '
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原本文件中的command 會抓不到其他套件，所以改用這樣的方式處理

mattwang44
mattwang44 reviewed Jun 4, 2024
View reviewed changes
dev.Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
mattwang44
mattwang44 reviewed Jun 4, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
mattwang44
mattwang44 reviewed Jun 4, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@mattwang44
Copy link
Member

@SivanYeh please help to merge/deploy this PR whenever you think it's good to go

@mattwang44 mattwang44 requested a review from SivanYeh June 11, 2024 05:54
@SivanYeh
Copy link
Collaborator

SivanYeh commented Jun 11, 2024 •
edited
Loading

@SivanYeh please help to merge/deploy this PR whenever you think it's good to go

There're several collaborations going on the same platforms within two weeks.
I may act more conservative atm lol.
Let me deploy a test branch "temp_master" these two weeks. If everything goes smooth, I will merge then.

SivanYeh
SivanYeh approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It worked well during these two weeks. I will merge it into master.
Thanks all!

@SivanYeh SivanYeh merged commit b9720c5 into pycontw:master Jun 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@SivanYeh SivanYeh SivanYeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rockleona @mattwang44 @SivanYeh