Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ccip): add test cases for ccip apis #1150

Merged
merged 16 commits into from
Oct 8, 2023
Merged

Conversation

erik1110
Copy link
Contributor

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)
    testing for attendee CCIP app unit test #1143

Description

Describe what the change is
You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly
self-describe enough about how you change the code.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. You may also want to refer
to how to wirte the perfect pull request

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (74b334a) 69.74% compared to head (a200f81) 70.80%.
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   69.74%   70.80%   +1.06%     
==========================================
  Files          85       85              
  Lines        3378     3381       +3     
==========================================
+ Hits         2356     2394      +38     
+ Misses       1022      987      -35     
Files Coverage Δ
src/sponsors/translation.py 100.00% <100.00%> (ø)
src/ccip/views.py 53.39% <50.00%> (+19.73%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ccip/tests/api/test_ccip.py Outdated Show resolved Hide resolved
@josix
Copy link
Collaborator

josix commented Sep 30, 2023

hi @erik1110, per discussion, please add the related entities like customEvents, and proposals to the fixtures so that the tests could simulate the actual scenario.

@erik1110
Copy link
Contributor Author

erik1110 commented Oct 6, 2023

hi @erik1110, per discussion, please add the related entities like customEvents, and proposals to the fixtures so that the tests could simulate the actual scenario.

OK, I will add another pull request!

@erik1110 erik1110 requested a review from josix October 6, 2023 06:21
@josix josix merged commit 2ac1eac into pycontw:master Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants