chore: remove deprecated schedule model, views, page, ...etc #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
5 times, most recently
from
e417987
to
6acba73
Compare
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
from
ef63fd2
to
956966c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
+ Coverage 71.19% 73.16% +1.96%
==========================================
Files 84 83 -1
Lines 3451 3115 -336
==========================================
- Hits 2457 2279 -178
+ Misses 994 836 -158 ☔ View full report in Codecov by Sentry. |
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
from
77662d4
to
e571f06
Compare
|
@erik1110 |
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
from
d012727
to
d5e160a
Compare
6 tasks
|
rebased |
|
Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time.... |
josix
force-pushed
the
rm-schedule-model-and-views
branch
from
58f179e
to
4bdb64d
Compare
josix
approved these changes
Apr 5, 2024
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
from
a1c5c71
to
ab80560
Compare
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
3 times, most recently
from
8f1a768
to
88b87eb
Compare
mattwang44
force-pushed
the
rm-schedule-model-and-views
branch
from
88b87eb
to
134b60e
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Before 2021, we used to have a schedule model storing the generated HTML code of schedule data, and being displayed on the schedule page. However, this behavior has been deprecated after we created the brand new front-end project in 2021.
Note that I only deleted/modified templates and statics from the 2023 code.
Steps to Test This Pull Request
Expected behavior