feat(settings.production.base): set GS_DEFAULT_ACL to publicRead #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
x
in the box that appliesSteps to Produce this PR
google-cloud-storage.json
under src/return default_storage if False else GoogleCloudStorage()
pycontw2016.base.py
docker-compose -f ./docker-compose-dev.yml up
Description
Describe what the change is
You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly
self-describe enough about how you change the code.
Setting
GS_DEFAULT_ACL
topublicRead
so that the return image URL would exclude the expiration period.Expected behavior
The retrieved image url would not contain the expiration period.
Related Issue
closes #1107
More Information
Screenshots