Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location and begin_time to talk and tutorial list's api #1088

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

lingin1230
Copy link
Contributor

…and tutorialList's api

Types of changes

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Add location and begin_time into events/talk, tutorial's api

Steps to Test This Pull Request

Please visit /api/events/speeches

Expected behavior

See if data with event_type talk or tutorial have location and begin_time

截圖 2022-07-02 下午6 48 10

@codecov-commenter
Copy link

Codecov Report

Merging #1088 (eb71ea2) into master (1b594f5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files          82       82           
  Lines        3340     3340           
=======================================
  Hits         2321     2321           
  Misses       1019     1019           
Impacted Files Coverage Δ
src/events/api/serializers.py 66.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b594f5...eb71ea2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants