Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration in enter_dev_env script for M1 machine #1082

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

josix
Copy link
Collaborator

@josix josix commented Jun 13, 2022

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Describe what the change is

  • setting default platform to linux/arm64 when using arm64 machine.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Follow instuctions in deploy_docker_dev.md

Expected behavior

Containers built successfully.

Related Issue

#1079

More Information

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. You may also want to refer
to how to wirte the perfect pull request

Created via Raycast

@josix josix requested a review from mattwang44 June 13, 2022 08:32
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwang44 mattwang44 merged commit 163b597 into master Oct 29, 2022
@mattwang44 mattwang44 deleted the update/enter_dev_env branch October 29, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants