feat(settings.production.base): set GS_DEFAULT_ACL to publicRead #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
有先測過這個真的有用嗎XD？ |
|
有喔我剛剛附錯圖了，如附圖
|
mattwang44
approved these changes
Dec 14, 2022
mattwang44
reviewed
Dec 14, 2022
| @@ -139,3 +139,4 @@ | |||
| os.path.join(BASE_DIR, "google-cloud-storage.json") | |||
| ) | |||
| GS_BUCKET_NAME = "pycontw-static" | |||
| GS_DEFAULT_ACL = "publicRead" | |||
There was a problem hiding this comment.
Thanks! I added that.
baby230211
approved these changes
Dec 14, 2022
|
logoUrl 後面的 expired time 沒了 |
josix
force-pushed
the
update/gcs-default-acl
branch
from
80d9b5b
to
9714a36
Compare
josix
force-pushed
the
update/gcs-default-acl
branch
from
9714a36
to
ec35573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesSteps to Produce this PR
google-cloud-storage.jsonunder src/return default_storage if False else GoogleCloudStorage()pycontw2016.base.pydocker-compose -f ./docker-compose-dev.yml upDescription
Describe what the change is
You don't need to explain HOW you change the code. Your code, including comments in the code should explicitly
self-describe enough about how you change the code.
Setting
GS_DEFAULT_ACLtopublicReadso that the return image URL would exclude the expiration period.Expected behavior
The retrieved image url would not contain the expiration period.
Related Issue
closes #1107
More Information
Screenshots
