Avoid attr("__repr__") in initialize_generic #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
approved these changes
Jul 23, 2020
|
Appveyor forgot how to use git and didn't clone the repository in one build. It's just a flake. |
bstaletic
force-pushed
the
arg_v-repr
branch
4 times, most recently
from
a9d4734
to
2d4a04b
Compare
If the default argument value is a class, and not an instance of a
class, `a.value.attr("__repr__")` raises a `ValueError`. Switching to
`repr(a.value)` makes this use case work.
Fixes pybind#2028
|
Green CI! |
|
Green, green, green. Everything green! Thanks, Boris! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default argument value is a class, and not an instance of a
class,
a.value.attr("__repr__")raises aValueError. Switching torepr(a.value)makes this use case work.Fixes #2028