Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, prepare test on Python 3.9 beta #2233

Merged
merged 8 commits into from
May 31, 2020
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 28, 2020

  • Fixed broken Sphinx job in CI by pinning Sphinx < 3. We can possibly fix this later on the latest Breathe + Sphinx.
  • Enabled NumPy on the 3.8 test
  • Added new 3.9 Beta test, expected fail for now.
  • Dropped the old PyPy 5.8 test because it was broken, added two PyPy 7.3 tests (2.7 and 3.6); these do (expected) fail, but we should be able to start fixing the tests, I hope. The 2.7 mode looks close (3-4 test failures), the 3.6 mode fails to build.

@henryiii henryiii changed the base branch from stable to master May 28, 2020 17:20
tests/test_stl_binders.py Show resolved Hide resolved
include/pybind11/pytypes.h Outdated Show resolved Hide resolved
include/pybind11/operators.h Outdated Show resolved Hide resolved
@henryiii henryiii marked this pull request as draft May 29, 2020 18:48
@henryiii
Copy link
Collaborator Author

henryiii commented May 29, 2020

This should have fixed Doxygen 3 + latest Breathe, I think, but did not:

breathe_doxygen_config_options = {
    'ENABLE_PREPROCESSING'   : 'YES',
    'MACRO_EXPANSION'        : 'YES',
}

@henryiii henryiii marked this pull request as ready for review May 29, 2020 21:33
@henryiii
Copy link
Collaborator Author

henryiii commented May 29, 2020

Okay, I think this is ready for review.

EDIT: Python 3.9 test is running on the built-in Python 3.6. Oops! Will fix.

EDIT: Fixed. Now it's hitting the warning and failing, as it should.

@henryiii henryiii marked this pull request as draft May 29, 2020 21:43
@henryiii henryiii marked this pull request as ready for review May 29, 2020 22:05
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henryiii henryiii changed the title Test on Python 3.9 beta Fix CI, prepare test on Python 3.9 beta May 30, 2020
@wjakob
Copy link
Member

wjakob commented May 31, 2020

This looks fantastic! Thank you very much @henryiii. I'm also glad that you updated PyPy. The 5.x release was super-flaky and sometimes caused test failures, maybe the new version will address this.

@wjakob wjakob merged commit a38e533 into pybind:master May 31, 2020
@henryiii henryiii deleted the patch-5 branch May 31, 2020 05:23
@henryiii henryiii added the ci related to the CI system label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants