-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more complete main window implementation #604
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 87.75% 85.42% -2.34%
==========================================
Files 40 43 +3
Lines 4705 5091 +386
==========================================
+ Hits 4129 4349 +220
- Misses 576 742 +166
☔ View full report in Codecov by Sentry. |
|
Thanks for checking in @larsoner! I was actually just gonna ping you today. I think the protocol is in good shape, and the qt backend is working pretty well. So it actually would be a great time for you to play with it and see if you can improve the ipywidgest backend. I have a simple I think you know ipywidgets better than I do, so if you had time and wanted to tinker a bit, i think just running |
it's true, and most of this PR is really just boilerplate adding the new protocols |
I am actually a bit of an |
This establishes the protocols and the qt backend for the main window elaboration discussed in #601.
This includes #597
it's turning into a large PR, so I might break it out into smaller ones, but this PR will serves as the cumulative progress.
cc @larsoner
for ease of review, here are the APIs this adds: