fix probe norm bug #656
Merged
fix probe norm bug #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smribet
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in probe generation, where non-zero pixels outside of the center beam caused normalization issues.
Note that the solution here makes use of the Probe.measure_disk method instead of the datacube.get_probe_size method which implement similar functionality to avoid breaking changes elsewhere for now. A more comprehensive consolidation of functionality (there is a third method with similar functionality in process.calibration.probe, as well as some redundant metadata storage) will be implemented in v15. For (upcoming) v14.15+, using Probe.measure_disk is recommended.