-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up refutation by parallelization #527
Speed up refutation by parallelization #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commits look good. thanks @astoeffelbauer. Can you also add docstrings for the new parameters that you have introduced and mention that None is the default?
Thanks for the comments @amit-sharma. I've made those updates. Since every refutation method can be sped up by itself, do you think it's really necessary to add the example with the parallel loop through multiple refutation methods at the end of the Getting Started Notebook. If set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @astoeffelbauer Left a few comments. We are getting there :) Happy to merge once these are in.
Hi @amit-sharma, thanks again for the comments. I implemented the parallelization for the The The other remaining ones are more complex and harder to parallelize I think, and I haven't had a chance to understand them fully yet. Please let me know if this is fine for now and if you have any other comments. Once we've resolved any last comments or issues, do you think we can finalize and merge in the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @astoeffelbauer! We can take up how to parallelize the other refuters in a future PR.
@all-contributors please add @astoeffelbauer for code. |
I've put up a pull request to add @astoeffelbauer! 🎉 |
Thank you @amit-sharma for all the comments and the help!! Hope this will be useful 😊 |
Hi @amit-sharma,
I've added parallelization to the random cause and the placebo refuter using
joblib
.Please let me know what you think of my implementation before I do the same with the rest. For example do you have a suggestion about how to avoid the inner function within
refute_estimate
which is not overly pretty imo.I also added to the Getting Started Notebook. Hope this is a good start for the feature.