Create estimation validation loop #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create an estimator for t=t_i and then find the value for the other values of t_i. This allows us to isolate the causal effect of t from y during the optimization process.
amit-sharma
reviewed
Apr 30, 2020
|
In a nutshell, the plan is to train on a partition of a |
amit-sharma
requested changes
May 5, 2020
There was a problem hiding this comment.
The logic is correct, but can be simplified in many cases.
Also there is a larger point of what to do when the pipeline actions contain only zero, noise or permute. does not make sense to create groups or validation set. I gave a suggestion in the inline comments. Let me know what you think.
- move func_args to the end of argument list - replace X_chunk by X_train
All function calls now pass func_args as a variable length keyworded argument list ( **kwargs ). Accordingly, all function calls and examples in the documentation have been changed.
amit-sharma
reviewed
May 5, 2020
amit-sharma
reviewed
May 5, 2020
amit-sharma
reviewed
May 5, 2020
amit-sharma
reviewed
May 5, 2020
amit-sharma
reviewed
May 5, 2020
- Move the no_estimator check out of the simulation loop - Replace np.zeros with None - Use a common variable validation_df to refer to the validation data
|
Thanks @Tanmay-Kulkarni101 . This looks ready to merge once you add a few tests. |
amit-sharma
reviewed
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of Dummy Outcome Refuter, so as to compare the behavior, keeping the value of the treatment constant.