Fix bug with consistency of RegressionEstimator one-hot encoding #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witching from pandas get_dummies to sklearn OneHotEncoder. Signed-off-by: DAVID RAWLINSON <[email protected]>
|
Hi, thanks for addressing this! Can you also add a unit test to cover this? |
…nd consistency on new data. Signed-off-by: DAVID RAWLINSON <[email protected]>
|
No problem, unit test added. NB Apologies in advance - will not be able to update PR from 14 to 27 Dec, away from computer! |
amit-sharma
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with consistency of RegressionEstimator one-hot encoding by switching from pandas get_dummies to sklearn OneHotEncoder.
See issue #1111