Call like instructions #2261
Merged
Call like instructions #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… determine and display future syscalls
… for emulation off for syscalls
… jumps groups are defined (non uniformly)
| @@ -104,7 +102,7 @@ def next_matching_until_branch(address=None, mnemonic=None, op_str=None): | |||
| if mnemonic_match and op_str_match: | |||
| return ins | |||
|
|
|||
| if set(ins.groups) & jumps: | |||
| if ins.groups_set & ALL_JUMP_GROUPS: | |||
There was a problem hiding this comment.
Considering this is called like 3 times in this file I wonder if we should make a property out of it or cache it...
There was a problem hiding this comment.
I think that caching it as a property would be a good call. I'll look to add some caching decorators on the getter functions of the PwndbgInstruction when we start hammering down on the performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "call-like" attribute to instructions. We previously relied on the capstone constant CS_GRP_CALL to identify call instructions, but this misses a handful of instructions that behave like calls, like a handful of "branch-and-link" instructions in MIPS that capstone doesn't label as calls. This makes the stepping through MIPS more clean, and makes things like nextcall work better on MIPS.