don't stack overflow when printing out array's that are self referential

pwl · May 6, 2015 · e816678 · e816678
1 parent 7661496
commit e816678
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/base/show.jl b/base/show.jl
@@ -155,7 +155,13 @@ function show_delim_array(io::IO, itr::AbstractArray, op, delim, cl, delim_one,
  x = itr[i]
  multiline = isa(x,AbstractArray) && ndims(x)>1 && length(x)>0
  newline && multiline && println(io)
- compact ? showcompact_lim(io, x) : show(io, x)
+ if is(x, itr)
+ print(io, "#= circular reference =#")
+ elseif compact
+ showcompact_lim(io, x)
+ else
+ show(io, x)
+ end
  end
  i += 1
  if i > i1+l-1
@@ -189,7 +195,11 @@ function show_delim_array(io::IO, itr, op, delim, cl, delim_one, compact=false,
  x, state = next(itr,state)
  multiline = isa(x,AbstractArray) && ndims(x)>1 && length(x)>0
  newline && multiline && println(io)
- show(io, x)
+ if is(x, itr)
+ print(io, "#= circular reference =#")
+ else
+ show(io, x)
+ end
  i1 += 1
  if done(itr,state) || i1 > n
  delim_one && first && print(io, delim)

diff --git a/test/show.jl b/test/show.jl
@@ -16,6 +16,16 @@ end
 s = "ccall(:f,Int,(Ptr{Void},),&x)"
 @test replstr(parse(s)) == ":($s)"
 
+# recursive array printing
+# issue #10353
+let
+ a = Any[]
+ push!(a,a)
+ show(IOBuffer(), a)
+ push!(a,a)
+ show(IOBuffer(), a)
+end
+
 # expression printing
 
 macro test_repr(x)