Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per docs,
getDeviceInterests
must acceptlimit
andcursor
args to be passed with query parameters in the API. Currently, API returns 100 results since limit implies with 100 as default value in API, so i first redesigned the endpoint caller function here to accept query params as object inparams
arg and reworked thegetDeviceInterests
method here to return value as Object that includescursor
field from API response and addlimit
andcursor
to method parameters.Also I've added a test for
params
arg in do-request.test.jsNotable Changes
getDeviceInterests
now returns Object instead of an Array.doRequest
function can have params arg in Object to represent query params in URLpotentially fixes #115