Update to new SDK, add the currently playing song and program status … #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the menu, use web key for getting song info as the previous key was expired. discord_game_sdk.dll will now need to be distributed with the game.
|
Oh also there's the .idea folder you probably didn't mean to push 😛 |
|
good, so I guess travis builds needs some update now for pushing the releases. (The .idea was pushed intentionally 'cause it's like CLion's dictionaries, coding style etc.. but no one cares I guess 😅) |
|
I actually used CLion to work on the changes, but I'm personally still not a big fan of committing personal settings. Everyone's build environment is different and all those settings get pushed with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new SDK, add the currently playing song and program status to the menu, use web key for getting song info as the previous key was expired. discord_game_sdk.dll will now need to be distributed with the app.
I went with the c bindings for the game sdk, but the c++ ones looked fine as well. I'm sure they could be swapped out relatively painless.
As well, I removed the "click to join" thing as it doesn't seem too useful unless you have a lot of people with this app instead.. but should be pretty easy/similar to before if you wanted to implement it.
P.S. I'm pretty bad with c/c++, I tried to stick to the existing style however. If there's anything incorrect, please let me know or feel free to fix it!