Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #123: improve performance of stripPrefix/stripSuffix; add tests #124

Merged
merged 1 commit into from
May 13, 2020
Merged

fixes #123: improve performance of stripPrefix/stripSuffix; add tests #124

merged 1 commit into from
May 13, 2020

Conversation

michaelficarra
Copy link
Contributor

Fixes #123. /cc @natefaubion

@michaelficarra michaelficarra mentioned this pull request May 13, 2020
Merged
@garyb
Copy link
Member

garyb commented May 13, 2020

Nice, thanks!

@garyb garyb merged commit ec6da8f into purescript:master May 13, 2020
@michaelficarra michaelficarra deleted the GH-123 branch May 13, 2020 20:34
@michaelficarra
Copy link
Contributor Author

michaelficarra commented May 13, 2020 •
edited
Loading

@garyb can you make a release so that purescript-contrib/purescript-parsing#93 can pull this in?

edit: Beat me to it. 4.0.2 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefaubion natefaubion natefaubion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stripPrefix performs full linear search in order to check if index is 0
3 participants
@michaelficarra @garyb @natefaubion