(PUP-3245) Profile function calls #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new evaluator implementation has a different code path for function calls, but this path didn't call out to the profiler to track that the call was made, this meant that new function calls were not showing up anywhere. This updates the call_function runtime to also profile that the call was made.
|
CLA signed by all contributors. |
adrienthebo
added a commit
that referenced
this pull request
Sep 15, 2014
…ling-for-functions (PUP-3245) Profile function calls
|
Merged in 5f076ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new evaluator implementation has a different code path for function
calls, but this path didn't call out to the profiler to track that the call
was made, this meant that new function calls were not showing up anywhere.
This updates the call_function runtime to also profile that the call was
made.