Don't send 103 early hints response when only invalid headers are used #3163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing code in
test\test_response_header.rb
, I noticed that when invalid headers are returned by the app with 'early hints', the first line of an 'early hints' response (HTTP/1.1 103 Early Hints
) is sent without any data/headers.This PR modifies the code in
puma/request.rb
to only send the 'early hints' response if at least one header is valid.Note that with the test changes, current master has the following errors:
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.