Migrate node_io to null safety #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffa11ee
to
061c311
Compare
Awjin
reviewed
Apr 21, 2021
| if (code is! int) { | ||
| throw ArgumentError('Integer value for exit code expected'); | ||
| } | ||
| Never exit(int code) { |
There was a problem hiding this comment.
Is there a reason for this behavior change?
There was a problem hiding this comment.
I'm trying to match the API for dart:io, which has exit take in a non-nullable integer and return the new Never type.
There was a problem hiding this comment.
I see. Worth documenting in the changelog?
Awjin
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the node_io code itself, but not the tests