update Go version to 1.21.x #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulumi/pulumi generally supports the two latest Go releases. Since 1.22.x came out, we dropped support for 1.20.x, and indeed compilation of the latest pulumi/pulumi source is failing with the latest Go version because of the missing `slices` package. Update CI to the latest supported Go version, so we are able to update pulumi/pulumi in this repo.
julienp
approved these changes
Feb 22, 2024
Frassle
approved these changes
Feb 22, 2024
tgummerer
added a commit
to pulumi/examples
that referenced
this pull request
Feb 22, 2024
pulumi/pulumi generally supports the two latest Go releases. Since 1.22.x came out, we dropped support for 1.20.x, and indeed compilation of the latest pulumi/pulumi source is failing with the latest Go version because of the missing slices package. Update CI to the latest supported Go version, so we are able to update pulumi/pulumi in this repo. This is similar to what we're doing in the templates repo in pulumi/templates#758
cnunciato
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulumi/pulumi generally supports the two latest Go releases. Since 1.22.x came out, we dropped support for 1.20.x, and indeed compilation of the latest pulumi/pulumi source is failing with the latest Go version because of the missing
slicespackage.Update CI to the latest supported Go version, so we are able to update pulumi/pulumi in this repo.
(I need to update to the latest pulumi/pulumi to get dev SDKs tested, work for that is in #756. But this feels separate enough to warrant a separate PR.)
We will also need to update the required CI jobs as the name changes based on the versions of the various toolchains. I'm not an admin in this repo, so I can't do that myself unfortunately. (Or maybe we could make only the sentinel job required, since that doesn't change, so would be more future proof)