Add deprecation message to ec2.Instance securityGroups

Fixes: #852
pulumi · Mar 20, 2020 · 065bcbe · 065bcbe
1 parent 0c13188
commit 065bcbe
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 3 deletions.
diff --git a/cmd/pulumi-resource-aws/schema.go b/cmd/pulumi-resource-aws/schema.go
diff --git a/cmd/pulumi-resource-aws/schema.json b/cmd/pulumi-resource-aws/schema.json
diff --git a/go.mod b/go.mod
@@ -1,7 +1,7 @@
 module github.com/pulumi/pulumi-aws
 
 require (
- github.com/aws/aws-sdk-go v1.29.18 //indirect
+ github.com/aws/aws-sdk-go v1.29.18 //ct
  github.com/hashicorp/aws-sdk-go-base v0.4.0
  github.com/hashicorp/terraform-plugin-sdk v1.7.0
  github.com/mitchellh/go-homedir v1.1.0

diff --git a/resources.go b/resources.go
@@ -891,6 +891,11 @@ func Provider() tfbridge.ProviderInfo {
  "instance_state": {
  CSharpName: "State",
  },
+ "security_groups": {
+ DeprecationMessage: "Use of `securityGroups` is discouraged as it does not allow for changes and" +
+ " will force your instance to be replaced if changes are made. To avoid this," +
+ " use `vpcSecurityGroupIds` which allows for updates.",
+ },
  },
  },
  "aws_internet_gateway": {Tok: awsResource(ec2Mod, "InternetGateway")},

diff --git a/sdk/dotnet/Ec2/Instance.cs b/sdk/dotnet/Ec2/Instance.cs
@@ -511,6 +511,7 @@ public InputList<Inputs.InstanceNetworkInterfacesArgs> NetworkInterfaces
  /// <summary>
  /// A list of security group names (EC2-Classic) or IDs (default VPC) to associate with.
  /// </summary>
+ [Obsolete(@"Use of `securityGroups` is discouraged as it does not allow for changes and will force your instance to be replaced if changes are made. To avoid this, use `vpcSecurityGroupIds` which allows for updates.")]
  public InputList<string> SecurityGroups
  {
  get => _securityGroups ?? (_securityGroups = new InputList<string>());
@@ -827,6 +828,7 @@ public InputList<Inputs.InstanceNetworkInterfacesGetArgs> NetworkInterfaces
  /// <summary>
  /// A list of security group names (EC2-Classic) or IDs (default VPC) to associate with.
  /// </summary>
+ [Obsolete(@"Use of `securityGroups` is discouraged as it does not allow for changes and will force your instance to be replaced if changes are made. To avoid this, use `vpcSecurityGroupIds` which allows for updates.")]
  public InputList<string> SecurityGroups
  {
  get => _securityGroups ?? (_securityGroups = new InputList<string>());

diff --git a/sdk/nodejs/ec2/instance.ts b/sdk/nodejs/ec2/instance.ts
@@ -515,6 +515,8 @@ export interface InstanceState {
  readonly rootBlockDevice?: pulumi.Input<inputs.ec2.InstanceRootBlockDevice>;
  /**
  * A list of security group names (EC2-Classic) or IDs (default VPC) to associate with.
+ * 
+ * @deprecated Use of `securityGroups` is discouraged as it does not allow for changes and will force your instance to be replaced if changes are made. To avoid this, use `vpcSecurityGroupIds` which allows for updates.
  */
  readonly securityGroups?: pulumi.Input<pulumi.Input<string>[]>;
  /**
@@ -667,6 +669,8 @@ export interface InstanceArgs {
  readonly rootBlockDevice?: pulumi.Input<inputs.ec2.InstanceRootBlockDevice>;
  /**
  * A list of security group names (EC2-Classic) or IDs (default VPC) to associate with.
+ * 
+ * @deprecated Use of `securityGroups` is discouraged as it does not allow for changes and will force your instance to be replaced if changes are made. To avoid this, use `vpcSecurityGroupIds` which allows for updates.
  */
  readonly securityGroups?: pulumi.Input<pulumi.Input<string>[]>;
  /**