Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TypeScript Azure Helm example to C# #949

Merged
merged 8 commits into from
Mar 22, 2021
Merged

Port TypeScript Azure Helm example to C# #949

merged 8 commits into from
Mar 22, 2021

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 19, 2021

No description provided.

azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 19, 2021

Another confusing thing for me, when building with a profile that has only .NET 5.0, I can do dotnet build on the example just fine, however pulumi up complains:

Diagnostics:
  pulumi:pulumi:Stack (azure-cs-aks-helm-dev):
    It was not possible to find any compatible framework version
    The framework 'Microsoft.NETCore.App', version '3.1.0' was not found.
      - The following frameworks were found:
          5.0.0 at [/nix/store/cic9309mdg3hky7cqwll30paa31mn4vq-dotnet-sdk-5.0.100/shared/Microsoft.NETCore.App]
    You can resolve the problem by installing the specified framework and/or SDK.
    The specified framework can be found at:
      - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=osx.10.15-x64
 
    error: an unhandled error occurred: Program exited with non-zero exit code: 150

When downgrading to .NET core 3.1 SDK it all works.

@t0yv0 t0yv0 linked an issue Mar 19, 2021 that may be closed by this pull request
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 20, 2021

Aha, so actually removing Repo: makes the examples work better across the languages. There is something fishy with Repo: invoking helm CLI to resolve things and it's different between C# and other providers. I'll take it to a separate ticket, this is ready to review.

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except formatting. Consider using an IDE or another tool to auto-format.

azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyConfig.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 22, 2021

Ah, it's my first time using VS Code in years, I bet it needs some opt-in setting to auto format, let me play with that.

@t0yv0
Copy link
Member Author

t0yv0 commented Mar 22, 2021

Tried to clean up, looking better @mikhailshilkov ?

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyCluster.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
azure-cs-aks-helm/MyStack.cs Outdated Show resolved Hide resolved
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 22, 2021

Hmmm I keep missing these. Let me try https://github.com/dotnet/format - I have been spoiled by gofmt.

@t0yv0 t0yv0 merged commit c7c0890 into master Mar 22, 2021
@pulumi-bot pulumi-bot deleted the azure-cs-aks-helm branch March 22, 2021 18:58
dixler pushed a commit that referenced this pull request Jan 21, 2022
* Port TypeScript Azure Helm example to C#

* Cleanup go example

* Simplify aks-helm examples further

* VSCode autoformat

* Address PR style feedback

* Use collection initializers

* Continue formatting fixes

* Apply dotnet-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port azure-ts-aks-helm example to C#
2 participants