-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port TypeScript Azure Helm example to C# #949
Conversation
Another confusing thing for me, when building with a profile that has only .NET 5.0, I can do
When downgrading to .NET core 3.1 SDK it all works. |
Aha, so actually removing Repo: makes the examples work better across the languages. There is something fishy with Repo: invoking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except formatting. Consider using an IDE or another tool to auto-format.
Ah, it's my first time using VS Code in years, I bet it needs some opt-in setting to auto format, let me play with that. |
Tried to clean up, looking better @mikhailshilkov ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits
Hmmm I keep missing these. Let me try https://github.com/dotnet/format - I have been spoiled by |
* Port TypeScript Azure Helm example to C# * Cleanup go example * Simplify aks-helm examples further * VSCode autoformat * Address PR style feedback * Use collection initializers * Continue formatting fixes * Apply dotnet-format
No description provided.