-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/update CosmosDB examples for native Azure #923
Conversation
// Create an Azure resource (Storage Account) | ||
var storageAccount = new Storage.StorageAccount("storageAccount", new Storage.StorageAccountArgs | ||
{ | ||
AccountName = "logicappdemosa21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - with 0.7.0 (autonaming) we should just let the provider handle the names here.
2. Set the required configuration variables for this program, and log into Azure: | ||
|
||
```bash | ||
$ pulumi config set azure:location westeurope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/azure/azure-nextgen (or azure-native)
# Create an Azure resource (Storage Account) | ||
storage_account = storage.StorageAccount( | ||
"storageAccount", | ||
account_name="logicappdemosa21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rely on autonaming here with 0.7.0.
@@ -0,0 +1,3 @@ | |||
pulumi>=2.0.0,<3.0.0 | |||
pulumi-azure-nextgen>=0.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to 0.7.0 (everywhere)
accountName: accountName, | ||
const accountKeys = pulumi | ||
.all([cosmosdbAccount.name, resourceGroup.name]) | ||
.apply(([cosmosdbAccountName, resourceGroupName]) => documentdb.listDatabaseAccountKeys({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was trying to find a neat way to unfold the list but punted :)
2. Set the required configuration variables for this program, and log into Azure: | ||
|
||
```bash | ||
$ pulumi config set azure:location westeurope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ pulumi config set azure:location westeurope | |
$ pulumi config set azure-nextgen:location westeurope |
Looks good overall. We can either merge with the existing azure-nextgen dependency (probably still want to fix the readme's config entries for setting location) and follow-up with a conversion to azure-native or do all of that now. Whatever you prefer @lblackstone |
I'll update to 0.7.0 on this PR. |
I'll merge this and open an azure-native PR for all examples |
* Add/update CosmosDB examples for native Azure * Python * C# WIP * Fixed C# * One more fix
No description provided.