Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure-nextgen-go-static-website example #919

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

lblackstone
Copy link
Member

No description provided.

go 1.15

require (
github.com/pulumi/pulumi-azure-nextgen/sdk v0.6.2-0.20210218161332-bbda61784b00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the latest alpha build?

ResourceGroupName: resourceGroup.Name,
AccountName: storageAccount.Name,
ContainerName: staticWebsite.ContainerName,
Type: &blobTypeBlock,
Copy link
Member

@mikhailshilkov mikhailshilkov Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want, we can remove a bunch of optional parameters (like Type here). Should I list them all? (I realize you copied those from TS but we can also clean that one up)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds good. I've just been copying the TS example, so open to suggestions on simplifying.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and I'll take a pass when we need to change to azure-native

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and I'll take a pass when we need to change to azure-native

I think this example needs to wait on the next provider release. I'm currently getting the following error: error: Resource type azure-nextgen:storage:StorageAccountStaticWebsite not found and it seems like some of the APIs aren't available in the current latest release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.6.1 should have all that's needed... Other languages are fine on it, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it working. I think I was missing a latest tag before.

@lblackstone lblackstone force-pushed the lblackstone/azure-ng-go-static-site branch from 8b6ca9f to bf9a4e8 Compare February 23, 2021 18:21
@lblackstone lblackstone force-pushed the lblackstone/azure-ng-go-static-site branch from bf9a4e8 to 5bceb76 Compare February 23, 2021 18:27
@lblackstone lblackstone marked this pull request as ready for review February 23, 2021 22:07
@lblackstone lblackstone merged commit 6b1a84e into master Feb 23, 2021
@pulumi-bot pulumi-bot deleted the lblackstone/azure-ng-go-static-site branch February 23, 2021 22:07
dixler pushed a commit that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants