Adding functions examples for azure-nextgen #915
Conversation
| // Run on Linux | ||
| Kind = "Linux", | ||
|
|
||
| // Premium SKU |
There was a problem hiding this comment.
Let's change to the Consumption plan (that's the default thing for Azure Functions)
| { | ||
| public FunctionsStack() | ||
| { | ||
| var resourceGroup = new ResourceGroup("functions-rg", new ResourceGroupArgs { ResourceGroupName = "functions-rg", Location = "westus2" }); |
| SiteConfig = new SiteConfigArgs | ||
| { | ||
| AlwaysOn = true, | ||
| LinuxFxVersion = "DOCKER|mcr.microsoft.com/azure-functions/python:2.0", |
There was a problem hiding this comment.
Hmm... This deploys the docker image, not our code, or am I wrong? I think this is not needed.
There was a problem hiding this comment.
This was copied from https://github.com/pulumi/examples/blob/master/azure-cs-functions-linux-app/FunctionsStack.cs#L82
Seems to be the base functions runtime image and it seemed to run our code still. However, doesn't work with the addition of the consumption sku. Removed now.
|
|
||
| [Output] public Output<string> Endpoint { get; set; } | ||
|
|
||
| static private Output<string> signedBlobReadUrl(Blob blob, BlobContainer container, StorageAccount account, ResourceGroup resourceGroup) |
There was a problem hiding this comment.
Nit
| static private Output<string> signedBlobReadUrl(Blob blob, BlobContainer container, StorageAccount account, ResourceGroup resourceGroup) | |
| private static Output<string> SignedBlobReadUrl(Blob blob, BlobContainer container, StorageAccount account, ResourceGroup resourceGroup) |
| { name: "runtime", value: "dotnet" }, | ||
| { name: "FUNCTIONS_WORKER_RUNTIME", value: "dotnet" }, | ||
| { name: "WEBSITE_RUN_FROM_PACKAGE", value: dotnetBlobSignedURL }, | ||
| { name: "WEBSITE_NODE_DEFAULT_VERSION", value: "~12" }, |
There was a problem hiding this comment.
Probably not needed for non-node functions?
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| <AzureFunctionsVersion>v2</AzureFunctionsVersion> |
There was a problem hiding this comment.
| <AzureFunctionsVersion>v2</AzureFunctionsVersion> | |
| <AzureFunctionsVersion>v3</AzureFunctionsVersion> |
| @@ -0,0 +1,138 @@ | |||
| // Copyright 2016-2020, Pulumi Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Thanks for the catch, updated.
| req_body = req.get_json() | ||
| except ValueError: | ||
| pass | ||
| else: |
There was a problem hiding this comment.
I think this is indented too far
There was a problem hiding this comment.
This is a shameless copy of https://github.com/pulumi/examples/blob/master/azure-ts-functions-raw/python/HelloPython/__init__.py.
That said I think the intent is that the else block is invoked only if no exception is raised (as opposed to a finally block).
Adding functions examples for azure-nextgen
No description provided.